Updates captureToBitmap in ViewCapture to treat API 34 the same way that all previous API works. #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…hat all previous API works. Because API 34 wasn't getting the surface, it was including the action bar and messing up the screenshots. By removing it, it will use the surface instead and it works perfectly. API 28 still does not work right with dialog boxes, but that is a known issue that we don't have a fix for yet. To test this, I added tests for every API level and fixed a bug where the action bar wasn't showing up in the test. PiperOrigin-RevId: 588915479
copybara-service
bot
force-pushed
the
piper_588915479
branch
from
9a5eb38 to
56f67d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates captureToBitmap in ViewCapture to treat API 34 the same way that all previous API works.
Because API 34 wasn't getting the surface, it was including the action bar and messing up the screenshots. By removing it, it will use the surface instead and it works perfectly.
API 28 still does not work right with dialog boxes, but that is a known issue that we don't have a fix for yet.
To test this, I added tests for every API level and fixed a bug where the action bar wasn't showing up in the test.